From 47afa95e0773ed3861d8630132a223d51f0340f4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn?= <me@tentakelfabrik.de>
Date: Fri, 21 May 2021 12:24:27 +0200
Subject: [PATCH] adding

---
 app/Commands/CrawlerRunCommand.php            | 29 ++++----
 app/Handlers/Action/ActionHandler.php         | 26 -------
 app/Handlers/Actions/ActionHandler.php        | 39 ++++++++++
 .../{Action => Actions}/ActionInterface.php   |  5 +-
 app/Handlers/Handler.php                      | 42 -----------
 app/Handlers/HandlerFactory.php               | 72 +++++++++++++++++++
 app/Handlers/Response/ResponseHandler.php     |  9 +--
 .../Response/ResponseHandlerInterface.php     |  2 +-
 .../CustomHandlers/Action/FileDownload.php    | 17 +++++
 resources/CustomHandlers/Action/FileMove.php  | 13 ----
 resources/CustomHandlers/Response/Rss.php     | 13 ++--
 11 files changed, 161 insertions(+), 106 deletions(-)
 delete mode 100644 app/Handlers/Action/ActionHandler.php
 create mode 100644 app/Handlers/Actions/ActionHandler.php
 rename app/Handlers/{Action => Actions}/ActionInterface.php (54%)
 delete mode 100644 app/Handlers/Handler.php
 create mode 100644 app/Handlers/HandlerFactory.php
 create mode 100644 resources/CustomHandlers/Action/FileDownload.php
 delete mode 100644 resources/CustomHandlers/Action/FileMove.php

diff --git a/app/Commands/CrawlerRunCommand.php b/app/Commands/CrawlerRunCommand.php
index 61e8f98..eaa7f7a 100644
--- a/app/Commands/CrawlerRunCommand.php
+++ b/app/Commands/CrawlerRunCommand.php
@@ -5,7 +5,9 @@ namespace App\Commands;
 use Illuminate\Console\Scheduling\Schedule;
 use LaravelZero\Framework\Commands\Command;
 use Illuminate\Support\Facades\Http;
-use SimpleXMLElement;
+
+use App\Handlers\HandlerFactory;
+
 
 class CrawlerRunCommand extends Command
 {
@@ -35,24 +37,23 @@ class CrawlerRunCommand extends Command
             'https://steadyhq.com/rss/insertmoin?auth=d37bffc9-9a84-4eed-95f6-3b6cb77c2406'
         ];
 
-        $handlerClass = $source->response_handler_class;
+        foreach ($sources as $source) {
 
-        $handler = new $handlerClass($source);
-        $response = $handler->getResponse();
+            // getting handler class and create object
+            $handlerClass = HandlerFactory::getResponseHandlerClass($source->response_handler_class);
+            $handler = new $handlerClass($source);
 
-        // if it is a 200
-        if ($response->ok()) {
-            $handler->run();
+            $response = $handler->getResponse();
 
-        // if there is an error on the source
-        } else if ($response->serverError()) {
+            // if it is a 200
+            if ($response->ok()) {
+                $handler->run();
 
-        }
-    }
-
-    private function get($url, $handler)
-    {
+            // if there is an error on the source
+            } else if ($response->serverError()) {
 
+            }
+        }
     }
 
     /**
diff --git a/app/Handlers/Action/ActionHandler.php b/app/Handlers/Action/ActionHandler.php
deleted file mode 100644
index a3a6226..0000000
--- a/app/Handlers/Action/ActionHandler.php
+++ /dev/null
@@ -1,26 +0,0 @@
-<?php
-
-namespace App\ResponseHandler;
-
-use App\Handlers\Handler;
-
-/**
- *
- *
- *
- */
-
-class ActionHandler extends Handler implements ActionHandlerInterface
-{
-    protected $data;
-
-    /**
-     *
-     *  @param mixed $data
-     *  
-     */
-    public function __construct($data)
-    {
-        $this->data = $data;
-    }
-}
\ No newline at end of file
diff --git a/app/Handlers/Actions/ActionHandler.php b/app/Handlers/Actions/ActionHandler.php
new file mode 100644
index 0000000..a7ff729
--- /dev/null
+++ b/app/Handlers/Actions/ActionHandler.php
@@ -0,0 +1,39 @@
+<?php
+
+namespace App\Handlers\Actions;
+
+/**
+ *
+ *
+ *
+ */
+
+class ActionHandler implements ActionHandlerInterface
+{
+    // data to process in a action
+    protected $data;
+
+    /**
+     *
+     *  @param  [type] $data
+     *  @return [type]
+     */
+    protected function processActions($source, $response, $data)
+    {
+        foreach($this->source->actions() as $action) {
+            HandlerFactory::getActionHandlerClass($action->response_handler_class);
+            $action = new ActionClass($this->source, $data);
+            $action->run();
+        }
+    }
+
+    /**
+     *
+     *  @param mixed $data
+     *
+     */
+    public function __construct($data)
+    {
+        $this->data = $data;
+    }
+}
\ No newline at end of file
diff --git a/app/Handlers/Action/ActionInterface.php b/app/Handlers/Actions/ActionInterface.php
similarity index 54%
rename from app/Handlers/Action/ActionInterface.php
rename to app/Handlers/Actions/ActionInterface.php
index eefcc9e..cc5be18 100644
--- a/app/Handlers/Action/ActionInterface.php
+++ b/app/Handlers/Actions/ActionInterface.php
@@ -1,12 +1,15 @@
 <?php
 
-namespace App\Handlers\Action;
+namespace App\Handlers\Actions;
 
 /**
+ *
  *
  *
  */
+
 interface ActionInterface
 {
+    // method to process data 
     public function run();
 }
diff --git a/app/Handlers/Handler.php b/app/Handlers/Handler.php
deleted file mode 100644
index 14fab0a..0000000
--- a/app/Handlers/Handler.php
+++ /dev/null
@@ -1,42 +0,0 @@
-<?php
-
-namespace App\Handlers;
-
-/**
- *
- *
- *
- */
-
-abstract class Handler
-{
-    /**
-     *  
-     *
-     *  @param  String $className
-     *  @return Mixed
-     *
-     */
-    protected function getHandlerClass(String $className)
-    {
-        $result = NULL;
-
-        // create class
-        $class = 'App\\Handlers\\'.$className);
-
-        // if not found check for custom handlers
-        if (class_exists($class)) {
-            $result = new $class();
-        } else {
-
-            // create class
-            $class = 'CustomHandlers\\'.$className;
-
-            if (class_exists($class)) {
-                $result = new $class();
-            }
-        }
-
-        return $result;
-    }
-}
\ No newline at end of file
diff --git a/app/Handlers/HandlerFactory.php b/app/Handlers/HandlerFactory.php
new file mode 100644
index 0000000..3267a54
--- /dev/null
+++ b/app/Handlers/HandlerFactory.php
@@ -0,0 +1,72 @@
+<?php
+
+namespace App\Handlers;
+
+use Exception;
+
+/**
+ *  Factory to getting Handler-Classes
+ *
+ *
+ */
+
+class HandlerFactory
+{
+    /**
+     *  getting handler class if exists
+     *
+     *  @param  String $className
+     *  @return Mixed
+     *
+     */
+    private static function getHandlerClass(String $prefix, String $className)
+    {
+        $result = NULL;
+
+        // create class
+        $class = 'App\\Handlers\\'.$prefix.'\\'.$className);
+
+        // if not found check for custom handlers
+        if (class_exists($class)) {
+            $result = new $class();
+        } else {
+
+            // create class
+            $class = 'CustomHandlers\\'.$prefix.'\\'.$className;
+
+            if (class_exists($class)) {
+                $result = new $class();
+            }
+        }
+
+        // if there is not class throw Exception
+        if ($result === NULL) {
+            thrown new Exception($prefix.'\\'.$className.' not Found!');
+        }
+
+        return $result;
+    }
+    /**
+     *
+     *
+     *  @param  String $className
+     *  @return Mixed
+     *
+     */
+    public static function getResponseHandlerClass(String $className)
+    {
+        return self::getHandlerClass('Response', String $className)
+    }
+
+    /**
+     *
+     *
+     *  @param  String $className
+     *  @return Mixed
+     *
+     */
+    public static function getActionHandlerClass(String $className)
+    {
+        return self::getHandlerClass('Actions', String $className)
+    }
+}
\ No newline at end of file
diff --git a/app/Handlers/Response/ResponseHandler.php b/app/Handlers/Response/ResponseHandler.php
index 23de907..9f5b35c 100644
--- a/app/Handlers/Response/ResponseHandler.php
+++ b/app/Handlers/Response/ResponseHandler.php
@@ -1,17 +1,18 @@
 <?php
 
-namespace App\ResponseHandler;
-
-use App\Handlers\Handler;
+namespace App\Handlers\Response;
 
 /**
  *
  *
  *
  */
-class ResponseHandler extends Handler implements ResponseHandlerInterface
+class ResponseHandler implements ResponseHandlerInterface
 {
+    // response
     protected $response;
+
+    //
     protected $source;
 
     /**
diff --git a/app/Handlers/Response/ResponseHandlerInterface.php b/app/Handlers/Response/ResponseHandlerInterface.php
index 5b8648f..f32148d 100644
--- a/app/Handlers/Response/ResponseHandlerInterface.php
+++ b/app/Handlers/Response/ResponseHandlerInterface.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\ResponseHandler;
+namespace App\Handlers\Response;
 
 /**
  *
diff --git a/resources/CustomHandlers/Action/FileDownload.php b/resources/CustomHandlers/Action/FileDownload.php
new file mode 100644
index 0000000..5089c15
--- /dev/null
+++ b/resources/CustomHandlers/Action/FileDownload.php
@@ -0,0 +1,17 @@
+<?php
+
+namespace CustomHandlers\Actions;
+
+/**
+ *
+ *
+ *
+ */
+
+class FileDownload extends ActionHandler
+{
+    public function run()
+    {
+        
+    }
+}
\ No newline at end of file
diff --git a/resources/CustomHandlers/Action/FileMove.php b/resources/CustomHandlers/Action/FileMove.php
deleted file mode 100644
index 4394ce6..0000000
--- a/resources/CustomHandlers/Action/FileMove.php
+++ /dev/null
@@ -1,13 +0,0 @@
-<?php
-
-namespace CustomHandlers\Actions;
-
-/**
- *
- *
- *
- */
-
-class FileMove extends ActionHandler {
-
-}
\ No newline at end of file
diff --git a/resources/CustomHandlers/Response/Rss.php b/resources/CustomHandlers/Response/Rss.php
index 6b44cad..ab15902 100644
--- a/resources/CustomHandlers/Response/Rss.php
+++ b/resources/CustomHandlers/Response/Rss.php
@@ -2,6 +2,9 @@
 
 namespace CustomHandlers\Response;
 
+use App\Handlers\Response\ResponseHandler;
+use SimpleXMLElement;
+
 /**
  *  Handle Response of a Rss Feed,
  *  response will parsed to SimpleXMLElement
@@ -35,13 +38,13 @@ class Rss extends ResponseHandler
      */
     public function run()
     {
+        // parse xml from body
         $xml = new SimpleXMLElement($this->response->body());
 
-        foreach($xml->channel->item as $item) {
-            foreach($this->actions as $action) {
-                $actionClass = $action->action_handler_class;
-                $action = new ActionClass($item);
-                $action->run();
+        // only process if xml is valid
+        if ($xml) {
+            foreach($xml->channel->item as $item) {
+                $this->processActions($item);
             }
         }
     }